Eli Collins <e...@assurancetechnologies.com> added the comment: The second patchset (9170231ebf14.diff) should implement all the changes you suggested in your second review (dated 2011-09-05).
--- The only non-addressed item in your second review was a request for clarification on a potential error I noticed (and described somewhat poorly). On later examination, I realized I was mistaken, so didn't want to trouble anyone further with it. (If you want details... I noticed that if a line ends with ";;", _pop_values() will call interpret() with an empty string. I initially though that would cause an error, but later realized it just means interpret() would return False, causing the line to be ignored, which is probably fine for that border case - especially since packaging.metadata has the same behavior for lines ending with ";"). ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue12424> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
