New submission from Stefan Krah <stefan-use...@bytereef.org>:
bytearray_getbuffer() checks for view==NULL. But this has never been
allowed:
PEP: "The second argument is the address to a bufferinfo structure.
Both arguments must never be NULL."
DOCS (3.2): "view must point to an existing Py_buffer structure
allocated by the caller".
A quick grep through the source tree shows no instances where
the middle argument of either PyObject_GetBuffer of bf_getbuffer
is NULL or 0.
Patch attached, all tests pass. I wouldn't be comfortable to
commit it without review though (it's just too strange).
BTW, the next conditional in bytearray_getbuffer ...
if (ret >= 0) {
obj->ob_exports++;
}
is also superfluous, since PyBuffer_FillInfo() cannot fail
if readonly==0.
----------
components: Interpreter Core
files: bytearray_getbuffer.diff
keywords: needs review, patch
messages: 154969
nosy: ncoghlan, pitrou, skrah
priority: normal
severity: normal
stage: patch review
status: open
title: bytearray_getbuffer: unnecessary code
type: resource usage
versions: Python 3.3
Added file: http://bugs.python.org/file24738/bytearray_getbuffer.diff
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14203>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
