Marc-Andre Lemburg <m...@egenix.com> added the comment:

Marc-Andre Lemburg wrote:
> Looking further I found this line in the Makefile:
> 
> ############################################################################
> # Importlib
> 
> Python/importlib.h: $(srcdir)/Lib/importlib/_bootstrap.py 
> $(srcdir)/Python/freeze_importlib.py
>         ./$(BUILDPYTHON) $(srcdir)/Python/freeze_importlib.py \
>             $(srcdir)/Lib/importlib/_bootstrap.py Python/importlib.h
> 
> Since the patch modified _bootstrap.py, make wants to recreate importlib.h,
> but at that time $(BUILDPYTHON) doesn't yet exist.

I now ran 'make' after applying the patches to have the importlib.h
recreated.

This setup looks a bit fragile to me.

I think it would be better to make creation of the importlib.h an
explicit operation that has to be done in case the Python code
changes (e.g. by creating a make target build-importlib.h),
with the Makefile only warning about a needed update instead
of failing completely.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14605>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to