Amaury Forgeot d'Arc <[email protected]> added the comment:
I think it would have been better to keep the ExFileObject class, and base it
on io.BufferedReader:
class ExFileObject(io.BufferedReader):
def __init__(self, tarfile, tarinfo):
raw = _FileInFile(tarfile.fileobj,
tarinfo.offset_data,
tarinfo.size,
tarinfo.sparse)
io.BufferedReader.__init__(self, raw)
The result is the same of course, but there is no need to special-case the
pre-3.3 API.
In addition, _FileInFile could probably inherit from io.RawIOBase.
----------
nosy: +amaury.forgeotdarc
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue13815>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
