R. David Murray <rdmur...@bitdance.com> added the comment: I checked the indent fix into the wrong branch in my repo. It's in the other patch. I could fix that if desired.
The reason for making the base class public is to allow subclassing. Perhaps that is not needed for Compat32, though. I don't think that the policy argument obsoletes the existing method options. It is easier to write: gen.flatten(msg, linesep='\r\n') than it is to write gen.flatten(msg, policy=msg.policy.clone(linesep='\r\n')) That is, when you want to make a change in just one method call, as opposed to globally, then the existing arguments are more convenient. That said, a section in What's New describing when it might be a good idea to move to a global policy setting vs using the existing arguments may be worthwhile. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue14731> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com