Hynek Schlawack <h...@ox.cx> added the comment:

Dear friends of ip addresses, I made something:

refactor dup code, minor janitoring, bump coverage

- remove duplicate netmask/hostmask code (it was identical in ipv4address & 
interface)
- make two ifs more pythonic
- Refactor and fix packed property for ipv6 addresses and networks. Apparently
  nobody has ever used this. :)
- Test coverage is now at 97%, the rest are mostly unreachable safeguards.

Please have a look at it if you will. The test suite passes of course.

That said, I'm pretty sure the constructor for IPv6Network is broken 
(particularly constructing from int and packed – also the the strict tests in 
these two cases don't make any sense as net mask is always ALL_ONES).

I'll be dreaming of ip addresses tonight. ;)

----------
Added file: 
http://bugs.python.org/file25824/ipaddress-refactor-and-bump-coverage.diff

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14814>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to