Gregory P. Smith added the comment:
> > Patch updated. It now implements the is*() methods for PyBytes. It
> > moves common code into a shared bytes_ctype.c and .h file so that
> > stringobject.c and bytesobject.c can share as much as possible.
>
> Did you move this into the stringlib subdirectory? That's more for
> sharing between PyString and PyUnicode, but I think there are more
> opportunities for sharing still, and PyString/PyBytes sharing makes
> sense separately.
Good idea, I haven't done that yet. At the moment it lives in
Include/bytes_ctype.h and Object/bytes_ctype.c directly. stringlib is a
good place for it and is something I pondered but hadn't gotten to. I'll do
that as I implement the remaining missing PyBytes_ methods to be in the next
update to this patch.
-gps
----------
nosy: +gps
__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__________________________________
<br><div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204,
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">> Patch
updated. It now implements the is*() methods for
PyBytes. It<br>> moves common code into a shared bytes_ctype.c
and .h file so that
<br>> stringobject.c and bytesobject.c can share as much as
possible.<br><br>Did you move this into the stringlib subdirectory? That's
more for<br>sharing between PyString and PyUnicode, but I think there are
more<br>
opportunities for sharing still, and PyString/PyBytes sharing makes<br>sense
separately.</blockquote><div><br>Good idea, I haven't done that yet. At the
moment it lives in Include/bytes_ctype.h and Object/bytes_ctype.c
directly. stringlib is a good place for it and is something I pondered
but hadn't gotten to. I'll do that as I implement the remaining
missing PyBytes_ methods to be in the next update to this patch.
<br><br>-gps<br><br></div></div>
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
