Guido van Rossum added the comment:
Does this mean I should hold off reviewing the patch?
On 10/16/07, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> Christian Heimes wrote:
> > * removed unused import of open in initstdio()
> > * fixed infinite loop in PyTokenizer_FindEncoding() by checking
> > tok-done == E_OK
>
> I found another bug in Python/import.c:call_find_method. The function
> mustn't set an encoding of ftp->mode contains 'b' for binary.
>
> if (strchr(fdp->mode, 'b') == NULL) {
> /* Python text file, get encoding from tokenizer */
> encoding = PyTokenizer_FindEncoding(fp);
> encoding = (encoding != NULL) ? encoding :
> PyUnicode_GetDefaultEncoding();
> }
>
> Christian
>
> __________________________________
> Tracker <[EMAIL PROTECTED]>
> <http://bugs.python.org/issue1267>
> __________________________________
>
__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1267>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
