Brett Cannon added the comment: On 10/20/07, Christian Heimes <[EMAIL PROTECTED]> wrote: > > Christian Heimes added the comment: > > Guido van Rossum wrote: > > You're right that a lot of this could be avoided if we used file > > descriptors consistently. It seems find_module() itself doesn't read > > the file; it just needs to know that it's possible to open the file. > > > > Rewriting everywhere that uses PyFile_FromFile[Ex] to use file > > descriptors doesn't seem too hard; there are only a few places. > > If I understand you right you want to alter the interface of > PyFile_FromFile and PyFile_FromFileEx from > > PyFile_FromFileEx(FILE *fp, char *name, char *mode, int (*close)(FILE*), > int buffering, char *encoding, char *newline) > > to > > PyFile_FromFileEx(int fd, char *name, char *mode, int (*close)(FILE*), > int buffering, char *encoding, char *newline) > > ? > > I could write a patch and remove int (*close)(FILE*), too. It's no > longer used by the functions.
Yes, I think you got it. -Brett __________________________________ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1267> __________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
