Hugo Lopes Tavares <hlt...@gmail.com> added the comment: Thanks for the review ezio.melotti.
He has notice a few things in my patch: * assertEquals is deprecated; should use assertEqual * the convention is assertEqual(result, expected), not assertEqual(expected, result) * it should handle quotes correctly * some lines were longer than 80 chars * add tests using inline flags (re.I instead of re.IGNORECASE) And I realized I was not covering the case where no flags are enabled (byte string, for instance). And I have fixed all this issues. And now I think this patch would work against py2x and py3k anyway. Attaching a new patch. ---------- Added file: http://bugs.python.org/file26453/issue13592_add_repr_to_regex_v2.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue13592> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
