Serhiy Storchaka added the comment:

Some conclusions of discussion at Python-ideas 

1. commonpath() should eat double slashes in input (['/usr/bin', '/usr//bin'] 
-> '/usr/bin').  In any case the current implementation eats slashes on output 
(['/usr//bin', '/usr//bin'] -> '/usr/bin', not '/usr//bin').

2. commonpath() should raise an exception instead of returning None on 
incompatible input.

3. May be commonpath() should eat also '.' components and return '.' instead of 
'' when relative paths have no common prefix. I am not sure.

In general the current patch looks good enough.


Python tracker <>
Python-bugs-list mailing list

Reply via email to