Serhiy Storchaka added the comment:

I have added a lot of comments in Rietveld. In general the patch looks good, 
but I have some style nitpicks and some more strong comments. Matt, please 
update the patch.

Tests should test both Python and C implementations.

I doubt if get rid of locking is right. Hash calculation and comparison of 
arguments can call Python code and this code can recursive use the wrapped 

Some benchmarks will be interesting.

I think this acceleration must necessarily be in 3.4.

components: +Extension Modules -Interpreter Core
stage: patch review -> needs patch

Python tracker <>
Python-bugs-list mailing list

Reply via email to