Serhiy Storchaka added the comment: > So this patch is a workaround for poor fseek performance in Microsoft's CRT, > it doesn't cause performance issues on Linux but saves quite some > milliseconds of startup time so I think it's worth the tradeoff.
I think some clarifying comments will be good in the code. In particular about the `dummy` variable. > I'll also upload zipimport_speedup-v3.patch updated to apply to current >default and with error handling for failing freads since the fseeks that the >patch replaces have gained error handling on the default branch in the mean >time. Perhaps getc() requires error handling too. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue8745> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
