STINNER Victor added the comment: > Here's the patch.
_set_cloexec() is still called whereas it is useless if the OS supports O_CLOEXEC... But the call must be kept because Linux < 2.6.23 just ignores O_CLOEXEC: we would have to check _fcntl.fcntl(fd, _fcntl.F_GETFD, 0) & _fcntl.FD_CLOEXEC to check if the kernel does really support O_CLOEXEC, which is overkill. The possibly useless syscall doesn't hurt. > (if the file is created with O_CREAT|O_EXCL, then by definition it's not a > symlink). Ah yes, because of O_EXCL. The patch looks good to me! ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue16860> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
