Vinay Sajip added the comment: Your suggestions are good, and I implemented them more or less as you suggested. Additional comments:
> it never makes sense to add more than one filter Except for readability. Although in theory one filter could do the work of several, it may be that different filters are added independently from configurations based on particular requirements. > Clarify that a handler can log the same record multiple times I've mentioned this as *emit* the same record multiple times. > Incidentally, is there any case where you would want the same handler to > process the same record more than once? I can't think why you'd ever want this - it would just duplicate information in the log output. > Clarify in the LogRecord section that the "name" attribute refers to the name > of the logger used in the end-user's code I think that part is clear enough by saying that it's the name of the logger used to log the event, but I've added a rider that this is so even when the event is emitted by a handler attached to an ancestor logger. > Clarify the last part of this sentence: "Note that filters attached to > handlers are consulted ..." Done, this should now be clearer. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue17007> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
