Jason R. Coombs added the comment:

Please disregard the patch 8bf88b31ebb7.

Antoine, Brian, or anyone else - would you please review the attached patch 
(b744517b90bc.diff)? It adds a test for creating directory symlinks that are 
non-local (don't depend on the current directory for reference), backs out 
Antoine's changes, and replaces them with directory detection that fixes this 
issue while maintaining directory detection.

I'm not super-confident about the implementation of the path-manipulation 
functions, and I would prefer to use the Python implementations of the 
path-manipulation (dirname and join) instead. If there are any suggestions in 
this regard, I'd appreciate them.

That said, the tests now pass for me on Windows (and I don't see why the tests 
wouldn't also pass on Linux).

----------
Added file: http://bugs.python.org/file29247/b744517b90bc.diff

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13772>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to