Charles-François Natali added the comment:

> Maybe I'm misinterpreting what you wrote but the test fails before the patch 
> and succeeds after it so what's the point in adding multiple tests with 
> different timeouts?

Well, the test you added tests explicitely for a value < 1s because
this specific bug was due to a rounding error, but I think it could be
interesting to check a couple more values, within a reasonable range
(not too long).
It's just a matter of calling it in a loop, but if you don't deem it
necessary, that's fine with me.

> Not sure what you refer to here. Feel free to submit a patch if you want.

See e.g. :
http://hg.python.org/cpython/file/413c0b0a105f/Lib/test/lock_tests.py#l65

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue17707>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to