Vajrasky Kok added the comment:

Hi Catherine,

I saw your patch. It looks good, except you are trying to copy the directory 
onto its subdirectory.

src_dir = tempfile.mkdtemp()
dst_dir = os.path.join(tempfile.mkdtemp(), 'destination')

I prefer it if you copy it to somewhere else. This would be better:

tmp_dir = self.mkdtemp()
src = os.path.join(tmp_dir, 'foo')
dst = os.path.join(tmp_dir, 'bar')

----------
nosy: +vajrasky

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue1666318>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to