Ezio Melotti added the comment: Patch LGTM. I'm getting 4 additional failures on 3.4: test_asyncio test_contextlib test_email test_statistics
* test_statistics is fixed by the attached patch. * test_email fails in Lib/email/_policybase.py:95 -- this probably deservers a separate issue. * test_contextlib fails in Lib/test/test_contextlib.py:107 even though these tests are decorated with @support.requires_docstrings (defined in Lib/test/support/__init__.py:1716). Even with -00 the _check_docstrings function seems to have a docstring (the exact line I used to run the tests is "./python -OO -m test -v test_contextlib"). * test_asyncio has lot of failures, and most of them look like: ====================================================================== ERROR: test_call_later (test.test_asyncio.test_events.PollEventLoopTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/wolf/dev/py/py3k/Lib/test/test_asyncio/test_events.py", line 1315, in setUp super().setUp() File "/home/wolf/dev/py/py3k/Lib/test/test_asyncio/test_events.py", line 188, in setUp events.set_event_loop(None) File "/home/wolf/dev/py/py3k/Lib/asyncio/events.py", line 423, in set_event_loop get_event_loop_policy().set_event_loop(loop) AttributeError: 'object' object has no attribute 'set_event_loop' Without -OO test_asyncio works fine. I haven't investigated this further. ---------- nosy: +ezio.melotti, r.david.murray Added file: http://bugs.python.org/file32652/issue19535_statistics.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue19535> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com