Antoine Pitrou added the comment: Some comments: - AbstractCryptoHashFunction should be called CryptoHashBase or something (but does it warrant being public? I don't think so) - having "Function" in a class name is a bit confusing to me. Why not simply "CryptoHash"? - you don't need to add a __slots__ to your ABCs, IMO - the default hexdigest() implementation looks a bit suboptimal to me, why not use binascii?
---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue18742> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
