Zachary Ware added the comment: Devguide patch review, review comment lines start with # (in column 1)
diff -r e665cddd6cde setup.rst --- a/setup.rst Sun Mar 23 19:31:22 2014 -0400 +++ b/setup.rst Tue Mar 25 07:47:54 2014 -0500 @@ -217,8 +217,9 @@ Windows ''''''' -The readme included in the solution has more details, especially on the -software needed to resolve the below mentioned build errors. +The readme http://hg.python.org/cpython/file/default/PCbuild/readme.txt # This should be a link, not just a URL thrown inline. 'readme' can be # the linked word. +included in the solution has more details, especially on the software +needed to resolve the below mentioned build errors. **Python 3.3** and later use Microsoft Visual Studio 2010. You can download Microsoft Visual C++ 2010 Express `from Microsoft's site @@ -238,6 +239,9 @@ <http://msdn.microsoft.com/en-us/library/hs24szh9%28v=VS.90%29.aspx>`_ and `here (2010) <http://msdn.microsoft.com/en-us/library/hs24szh9%28v=vs.100%29.aspx>`_. +Because the Python solution file uses Solution Folders, VS Express will warn +you about that fact every time you open the ``pcbuild.sln`` file. You can +safely dismiss the warning with no impact on your ability to build Python." # What fact? If you're going to copy my words verbatim, copy all of them. # Otherwise, rewrite them so it makes sense. To build from the Visual Studio GUI, open the ``pcbuild.sln`` solution file with Visual Studio. Choose the :menuselection:`Build Solution` option @@ -267,6 +271,7 @@ ``PCBuild\amd64\python_d.exe``. If you are compiling in release mode (which you shouldn't, in general), replace ``python_d.exe`` with ``python.exe``. + # No need to add a blank line here. .. _build_troubleshooting: Troubleshooting the build ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue17846> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com