Serhiy Storchaka added the comment:

Both patch are almost equivalent (my patch is much simpler but perhaps 
Matthew's approach is more correct in long perspective).

Unfortunately Rietvield doesn't work with Matthew's patch, so I have added my 
comments here.

> -                (!ctx->match_all || ctx->ptr == state->end)) {
> +                ctx->ptr == state->end) {

Why this check is not needed anymore?

> -                    status = SRE(match)(state, pattern + 2*prefix_skip);
> +                    status = SRE(match)(state, pattern + 2*prefix_skip, 
state->match_all);

> -            status = SRE(match)(state, pattern + 2);
> +            status = SRE(match)(state, pattern + 2, state->match_all);

state->match_all is used but it is never initialized.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20998>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to