Marc-Andre Lemburg added the comment:

Caelyn: Thanks for the patch.

Some comments:

* Please use aliased=False instead of aliased=0 in the patch.
* It would be great if you could enhance the test a bit to actually check the 
return value. This would need a mock of the os.uname API for the test.
* Doc string "if "aliased" is true" should read "If aliased is true"

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7850>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to