Tal Einat added the comment:

Changes LGTM.

This module could certainly use some cleanup and updates. For example, 
last_changed should be a property and always accessed one way (instead of 
either .mtime() or .last_changed) and should be initialized to None instead of 
zero to avoid ambiguity, and the and/or trick should be replaced with if/else. 
Would anyone review such a patch if I created one?

----------
nosy: +taleinat

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue21469>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to