Tal Einat added the comment: I don't think the patch should currently be committed.
I agree with Terry: we should first fix the issue whereby the key config is read repeatedly. Given such a fix, the problematic "known_invalid" workaround in the patch would no longer be necessary. As a side note, I think the method used in the patch to check if a binding is good. Ideally it would be the final check done after a simpler syntax check, since a syntax check could give more informative error messages. Also, there are two other more technical issues with the patch; I mentioned them in the patch review system. ---------- nosy: +taleinat _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue11437> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
