Alexander Belopolsky <[EMAIL PROTECTED]> added the comment:
On Mon, Mar 17, 2008 at 9:51 AM, Alexandre Vassalotti <
[EMAIL PROTECTED]> wrote:
>
> Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment:
>
> .. Although I haven't reviewed this
> patch yet, I find the naming of the `ustr` variable confusing -- e.g. is
> it a bytes object or a unicode object?
There is no `ustr` variable , you probably mean `uarg`. If so, it is
not introduced by the patch. To me the patch looks straightforward and
correct, but a unit test should be added. Some additional refactoring is
due for getargs.c (does py3k support builds without Py_USING_UNICODE?), but
the bug fix should not wait for that.
Added file: http://bugs.python.org/file9688/unnamed
__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2298>
__________________________________
<br><br><div class="gmail_quote">On Mon, Mar 17, 2008 at 9:51 AM, Alexandre
Vassalotti <<a href="mailto:[EMAIL PROTECTED]">[EMAIL PROTECTED]</a>>
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Alexandre Vassalotti <<a href="mailto:[EMAIL PROTECTED]">[EMAIL
PROTECTED]</a>> added the comment:<br>
<br>.. Although I haven't reviewed this<br>
patch yet, I find the naming of the `ustr` variable confusing -- e.g. is<br>
it a bytes object or a unicode object? </blockquote><div><br>There is no `ustr`
variable , you probably mean `uarg`. If so, it is
not introduced by the patch. To me the patch looks straightforward
and correct, but a unit test should be added. Some additional refactoring
is due for getargs.c (does py3k support builds without Py_USING_UNICODE?), but
the bug fix should not wait for that.<br>
</div></div><br>
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
