Martin Panter added the comment: Some more points:
* I suggest adding something like this to the documentation: exception nntplib.NNTPConnect[ion]Error Exception raised when the server unexpectedly shuts down the connection. * The tests should use BytesIO rather than StringIO. Other than that, I think monkey-patching the file attribute in the tests is fine; that’s probably the way I would do it! * The new exception should be added to __all__. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue1186900> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
