STINNER Victor added the comment:

The patch doesn't look correct. Ioctl() reduces the overhead in term of
syscalls (1 vs 2).

What is the errno value on failure? We should remember that ioctl() doesn't
work and fallback to fcntl(). It would be more portable. Similar check is
already done for O_TMPFILE and O_CLOEXEC for example.

See the PEP 446.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue22258>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to