Yury Selivanov added the comment:

Antony, I agree regarding the poor naming of '_sanitize_dir()' helper. As for 
your other suggestion, I think such a refactoring will actually make code 
harder to follow (+ it's more invasive). Generally, I'm in favour of 
transforming parameters like 'dir' closer to the beginning of the method's 
code, so that it's immediately obvious what's going on, and is also easier to 
put debug code [like 'print("mkdtemp call for: ", dir)'].

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue20267>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to