Antoine Pitrou added the comment:

Thanks for the updated patch, Cédric. Just some remarks:

- the documentation should mention that the return value is still a string
- the documentation needs a "versionadded" marker next to the new function
- have you already signed the contributor's agreement? otherwise you should 
sign it at https://www.python.org/psf/contrib/contrib-form/

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue13918>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to