Gregory P. Smith added the comment:
Haha, yes, that description and patch look correct. Thanks!
Fortunately this bug is low impact as this was just a sanity check and the
calling code from subprocess.py was already passing the correct data in.
An ideal regression test: An explicit unittest that calls the _posixsubprocess
API with some bad sequences of values in fds_to_keep and uses assertRaises to
check for the appropriate ValueError("bad value(s) in fds_to_keep") coming out
of it...
----------
assignee: -> gregory.p.smith
priority: normal -> low
stage: -> patch review
type: -> behavior
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23564>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
