Steve Dower added the comment:

I don't think we should be using PyMODINIT_FUNC for builtin modules, since that 
will make the init functions publicly available from python35.dll. That said, I 
do like being able to be consistent here... can we define PyMODINIT_FUNC 
differently when building pythoncore? That at least would keep the definitions 
in the same place if we ever change it (and since there's an open PEP regarding 
extension modules, it doesn't seem impossible).

The change for pyexpat looks right, since that's an external module. I have no 
ideas why PyMODINIT_FUNC wouldn't always be defined there.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23685>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to