Berker Peksag added the comment: Thanks for the patch, John.
> I'm under the impression that the final patch will need to include a test > that confirms the patch worked, Correct. You could convert the reproducers in msg239445 to a test case. The patch looks good to me. I think you'll also need to add a similar check to buffered_read1(): >>> from io import * >>> b = BufferedReader(BytesIO(b"12")) >>> b.read(1) b'1' >>> b.close() >>> b.peek() Traceback (most recent call last): File "<stdin>", line 1, in <module> ValueError: peek of closed file >>> b.read1(1) Segmentation fault (core dumped) ---------- nosy: +berker.peksag stage: needs patch -> patch review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23796> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
