New submission from pankaj.s01: Hi, There is dead code reported in this issue and I think no need to check for NULL of 'handler' in function faulthandler_fatal_error() and file Python-3.4.3/Modules/faulthandler.c . where 'handler' is pointed to staic array faulthandler_handlers[] which never will be null inside loop with faulthandler_nsignals value and doesn't means to check for NULL outside of loop. but if there is possibility of 'handler' to be NULL then it should be check inside the loop until handler->signum is not equal to signum and then break;
---------- components: Extension Modules files: Python-3.4.3-faulthandler.patch keywords: patch messages: 244195 nosy: pankaj.s01 priority: normal severity: normal status: open title: Dead Code of Handler check in function faulthandler_fatal_error() type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file39522/Python-3.4.3-faulthandler.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue24302> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
