Robert Collins added the comment:

The change in exec doesn't make sense to me (but see lower :))

__file__ should be in globals, not locals, right?

Also if it is right, then exec(foo, g) should be equivalent :)

The reset of the patch looks ok. But I can see your patch shows this breaking - 
I'm guessing its one of the things I keep forgetting about module scope 
evaluation and the import system - anyhoo.

Applying to 3.6.

Also looking at it the saving of argv is still broken even with your patch - 
the original argv is mutated, and the /name/ not the /value/ is restored. We 
should rebind argv to the copy, then restore the binding. But that can be done 
later.

----------
nosy: +rbcollins

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue23426>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to