Serhiy Storchaka added the comment:
I have added comments on Rietveld. Besides few stylistic nitpicks
Issue23883_support_check__all__.v5.patch LGTM.
> But passing "self" to it feels a bit weird.
This is not new. There are other testing helpers in test.support that needs
passing "self". If the helper is used many times in one test class, I prefer to
make a method:
class SomeTest(TestCase):
check_something = test.support.check_something
def test_foo():
self.check_something('foo')
def test_bar():
self.check_something('bar')
But in this case I'm happy with the current API.
----------
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue23883>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
