New submission from STINNER Victor:
Currently, the Python parser emits ast.Tuple AST nodes which are compiled to
multiple LOAD_xxx instructions followed a final BUILD_TUPLE instruction. The
Python peephole optimizer detect LOAD_CONST x n + BUILD_TUPLE instructions to
replace it directly with a tuple constant.
IHMO it's better to implement this optimization early at the AST level in an
AST optimizer. The PEP 511 proposes to add a new ast.Constant AST node for that.
With this new AST node, the AST optimizer can emit tuple constants, but also
any kind of constant like frozenset. For example, it's also possible to
optimize "x in {1, 2}" to "x in frozenset({1, 2})" where frozenset({1, 2}) is a
constant (don't call frozenset type at runtime). (Again, this optimization is
already implemented in the peephole optimizer, it's just an example.)
Attached patch adds the new ast.Constant type but update also code consuming
AST to handle this new kind of node:
* add the node: Parser/Python.asdl, Parser/asdl.py, Parser/asdl_c.py
* generated changes: Include/asdl.h, Include/Python-ast.h, Python/Python-ast.c
* accept the node kind: Python/symtable.c, Python/ast.c
* accept Constant instead of Num or Str: Lib/ast.py, Python/future.c,
Tools/parser/unparse.py
* emit constants to bytecode: Python/compile.c
I didn't change the compiler to emit directly ast.Constant nodes to reduce the
impact on the backward compatibility. This change can be done. An AST optimizer
is responsible to convert NameConstant (False, True, None), Num (int, float,
complex), Str, Bytes, Tuple to Constant. Example with fatoptimizer:
https://github.com/haypo/fatoptimizer/blob/2d794f511fe23ccde320725c6d12ce5ce8ffbdfe/fatoptimizer/convert_const.py
ast.Constant also simplifies AST optimizers: no need to check each time if a
node is constant or not.
Adding a new kind of node was already proposed in the old issue #11549: the
patch adds ast.Lit (it was proposed to rename it to ast.Literal).
----------
files: constant.patch
keywords: patch
messages: 258528
nosy: benjamin.peterson, brett.cannon, haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: PEP 511: Add ast.Constant to allow AST optimizer to emit constants
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file41647/constant.patch
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26146>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
