Martin Panter added the comment:

The two changes to look okay to me, although they will need 
updating since the Issue 24841 changeover to

But I don’t think it is a good idea to add ENOTCONN to the list of errors 
ignored by all transient_internet() tests. In most cases, ENOTCONN suggests a 
programming error, not a network problem. I think a better solution would be to 
call connect_ex() again in test_non_blocking_connect_ex(), and retrieve the 
result (probably also ECONNREFUSED like the other failures, or 0 if successful).

nosy: +martin.panter

Python tracker <>
Python-bugs-list mailing list

Reply via email to