Eryk Sun added the comment:

I get the following warnings:

..\Modules\posixmodule.c(7422): warning C4090: 'function': different 'const' 
qualifiers [...]
..\Modules\posixmodule.c(7423): warning C4090: 'function': different 'const' 
qualifiers [...]

        target_is_directory |= _check_dirW(src->wide, dst->wide);
        result = Py_CreateSymbolicLinkW(dst->wide, src->wide,
                                        target_is_directory);

..\Modules\posixmodule.c(7429): warning C4090: 'function': different 'const' 
qualifiers [...]

        result = Py_CreateSymbolicLinkA(dst->narrow, src->narrow,
                                        target_is_directory);

You can change _check_dirW to use LPCWSTR parameters, or const wchar_t * to be 
consistent with _check_dirA. In this context I prefer the Windows typedefs:

    _check_dirW(LPCWSTR src, LPCWSTR dest)
    _check_dirA(LPCSTR src, LPCSTR dest)

Change Py_CreateSymbolicLink[W|A] to use LPC[W]STR, which is how it's declared 
in Winbase.h:

    static DWORD (CALLBACK *Py_CreateSymbolicLinkW)(LPCWSTR, LPCWSTR, DWORD) = 
NULL;
    static DWORD (CALLBACK *Py_CreateSymbolicLinkA)(LPCSTR, LPCSTR, DWORD) = 
NULL;

----------
nosy: +eryksun

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue26708>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to