Mark Dickinson added the comment: [Serhiy, on the second patch] > Disadvantages are that this changes behavior ignoring overriding > as_integer_ratio() and __abs__() and slightly slows down Python > implementation.
None of those seem like big issues to me. Certainly we shouldn't care too much about slowing down the Python implementation a bit more, and I think it's reasonable to say that code that's overriding as_integer_ratio (or `__abs__`) and then expecting that override to be picked up and used in `Decimal.from_float` is on its own. > Advantages are that this fixes also issue26975 and slightly speeds up C > implementation. Sounds pretty good to me! I'll let Stefan review the patch properly, but this seems like a good solution to me. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26974> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
