Martin Panter added the comment: I merged Victor’s patch with the current code and addressed most of the comments:
* restore re.escape() * single "-l" + name argument * copy with dict(os.environ) * redirect GCC stderr=STDOUT * changed tempfile cleanup to try / finally I also added a test case. I kept Victor’s behaviour of not raising OSError when the command is missing. I think this should be considered separately, and only changed for 3.6+, if at all. The buggy code was added in Issue 4861. I only have Linux and GCC, but I briefly tested each platform-specific branch by hacking the “if” statements and creating mock crle, ldconfig, etc commands, so I am somewhat confident that everything is still working. ---------- stage: needs patch -> patch review versions: -Python 3.4 Added file: http://bugs.python.org/file42796/ctypes_util_popen-3.py3.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue22636> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
