Jelle Zijlstra added the comment: I think the patch needs more tests, including: - Comparing a partial against some other objects - Comparing two partials with a different function - Comparing two partials with different args
You also need to check each call to PyObject_RichCompareBool for error (it returns -1 on error). I believe the current implementation would silently ignore the error. This behavior should also be tested. Rietveld is not picking up this diff, maybe because it is a git rather than an hg diff. Generating the diff with hg will make it easier to review. ---------- nosy: +Jelle Zijlstra _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue21130> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
