Alexander Belopolsky added the comment:

>From review comments:

Lib/datetime.py:1482: def combine(cls, date, time, tzinfo=True):
On 2016/08/01 08:47:14, SilentGhost wrote:
> This strikes me as an odd default value, why not use a more conventional None?

This is the same default as used in the .replace() methods.  Arguably, a proper 
sentinel value would be a better choice, but I think True delivers better 
performance.  In any case, this is not something I would change without 
consulting with the PyPy folks.

See 
<http://bugs.python.org/review/27661/diff/18026/Lib/datetime.py#newcode1482>.

----------
stage: patch review -> commit review

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue27661>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to