Berker Peksag added the comment:

This looks pretty good to me, thanks! I have two minor suggestions:

1. It would be better to make "Quick search" a placeholder:

   <input type="text" name="q" placeholder="{{ _('Quick search') }}" />

2. <li class="right"> will add an unnecessary border in search page. I'd change 
it to

   <li{%- if pagename != "search" and builder != "singlehtml" %} 
class="right"{% endif %}>

Also,

    +form.inline-search input {
    +    display: inline;
    +}

may cause weird compatibility problems in some (old?) browsers. We can change 
it to use display: inline-block instead.

Is there a way to send this to upstream Sphinx?

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue19489>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to