STINNER Victor added the comment: Serhiy Storchaka: "LGTM."
Oh, you posted your comment while I was pushing the patch after Brett wrote LGTM on the review (not on the bug tracker). > Maybe use size_a instead of Py_SIZE(z)? > And look at "sign". Currently it takes values 1 and -1. Is it worth to > replace it with boolean variable "negative"? Or Py_ssize_t variable size_z > that takes values size_a and -size_a? Hum, I don't know what is the best. I don't think that it has an impact on performance. Feel free to modify directly the code, your proposed changes look safe and simple enough. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue27786> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
