Chris Withers <[EMAIL PROTECTED]> added the comment:

Hi George,

I haven't looked at your patch but that fact that there are no unit
tests and you talk about copying and pasting code, I'd suggest this
might not be a good patch.

Refactor so code is only in one place rather than copying and pasting,
and make sure you write extensive unit tests, especially for things like
date/time...

cheers,

Chris

_______________________________________
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3250>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to