Adrian Chan added the comment:

I've attached a potential fix for this issue.

While trying to fix this, I noticed that I coudn't assume that I just need to 
ensure that each line has a newline. If I always ensure each line in diffline 
has a newline, then the fourth test in testAssertMultilineEqual (in 
Lib/unittest/test/test_assertions.py) fails because standardMsg in 
assertMultiLineEqual in Lib/unittest/case.py is just one line without a 
newline. To sidestep this problem, I made it so that I only ensure there is a 
newline for each line if and only if there is more than one line in difflines. 
However, I'm not sure that I can assume there should be a newline in cases 
similar to the fourth test (where longMessage is set to true and a 'msg' is 
passed) in testAssertMultilineEqual but where there is more than one line in 
standardMsg in assertMultiLineEqual.

----------
Added file: http://bugs.python.org/file44679/fix_24780.patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue24780>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to