New submission from Bert JW Regeer:

I am the current maintainer of WebOb, and noticed that on Python 3.6 and 3.7 I 
noticed that a test started failing.

Granted, the test is checking the size of the file created and it is not the 
brightest idea in a test, but it's been stable since Python 2.5...

https://travis-ci.org/Pylons/webob/jobs/176505096#L224

shows the failure.

_________________________ test_response_file_body_tell _________________________
    def test_response_file_body_tell():
        import zipfile
        from webob.response import ResponseBodyFile
        rbo = ResponseBodyFile(Response())
        assert rbo.tell() == 0
        writer = zipfile.ZipFile(rbo, 'w')
        writer.writestr('zinfo_or_arcname', b'foo')
        writer.close()
>       assert rbo.tell() == 133
E       assert 145 == 133
E        +  where 145 = <bound method ResponseBodyFile.tell of <body_file for 
<Response at 0x7fa6291f9eb8 200 OK>>>()
E        +    where <bound method ResponseBodyFile.tell of <body_file for 
<Response at 0x7fa6291f9eb8 200 OK>>> = <body_file for <Response at 
0x7fa6291f9eb8 200 OK>>.tell
tests/test_response.py:608: AssertionError

I am not sure that this is necessarily a bug, but it would be good to know why 
files are no longer generated the same way.

----------
messages: 280992
nosy: X-Istence
priority: normal
severity: normal
status: open
title: zipfile increase in size
type: resource usage
versions: Python 3.6, Python 3.7

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28719>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to