Xavier de Gaye added the comment: > getandroidapilevel-3.patch: Updated version of getandroidapilevel.patch: > replace "runtime" with "build time" in the doc :-) Remove also "version > 0" > check in support/__init__.py.
LGTM > About the version > 0 check: would it make sense to add the check in > configure.ac? I guess that it was Xavier who wrote the test in > support/__init__.py? The version > 0 check was done because sysconfig.get_config_var() returns 0 when a variable is found as '#undef' in pyconfig.h. As a reference, the list of the existing API levels with their corresponding Android versions and names: Android Version Released API Level Name Android 7.1 October 2016 25 Nougat Android 7.0 August 2016 24 Nougat Android 6.0 August 2015 23 Marshmallow Android 5.1 March 2015 22 Lollipop Android 5.0 November 2014 21 Lollipop Android 4.4W June 2014 20 Kitkat Watch Android 4.4 October 2013 19 Kitkat Android 4.3 July 2013 18 Jelly Bean Android 4.2-4.2.2 November 2012 17 Jelly Bean Android 4.1-4.1.1 June 2012 16 Jelly Bean Android 4.0.3-4.0.4 December 2011 15 Ice Cream Sandwich Android 4.0-4.0.2 October 2011 14 Ice Cream Sandwich Android 3.2 June 2011 13 Honeycomb Android 3.1.x May 2011 12 Honeycomb Android 3.0.x February 2011 11 Honeycomb Android 2.3.3-2.3.4 February 2011 10 Gingerbread Android 2.3-2.3.2 November 2010 9 Gingerbread Android 2.2.x June 2010 8 Froyo Android 2.1.x January 2010 7 Eclair Android 2.0.1 December 2009 6 Eclair Android 2.0 November 2009 5 Eclair Android 1.6 September 2009 4 Donut Android 1.5 May 2009 3 Cupcake Android 1.1 February 2009 2 Base Android 1.0 October 2008 1 Base > I suggest to start to add sys.getandroidapilevel(), and then discuss how to > expose (or not) the runtime version. Agreed and thanks for the patch Victor :) ---------- components: +Interpreter Core stage: -> patch review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue28740> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
