Xiang Zhang added the comment:

> The code looks too complex.

It is if looking at the patch alone. But the skill is used across stringlib and 
the only thing new is the bitwise operation.

str/bytes.count is not critical but not bad if it could be optimized and 
especially the effect is significant for long data.

I am not favour of rejecting it now but set priority to low.

----------
priority: normal -> low

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue28921>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to